[coreboot-gerrit] New patch to review for coreboot: 8a4eab9 Partially revert "AMD Inagua: broadcom.c: Add missing prototype for `broadcom_init()`"

Jens Rottmann (JRottmann@LiPPERTembedded.de) gerrit at coreboot.org
Wed Apr 3 10:42:42 CEST 2013

Jens Rottmann (JRottmann at LiPPERTembedded.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3012


commit 8a4eab961e543cc679d048e9523f3f992180debf
Author: Jens Rottmann <JRottmann at LiPPERTembedded.de>
Date:   Wed Apr 3 10:12:55 2013 +0200

    Partially revert "AMD Inagua: broadcom.c: Add missing prototype for `broadcom_init()`"
    Commit 5d741567 added a prototype to broadcom.c to fix a warning.  This part
    is fine.
    It also changed mainboard.c to #include broadcom.c.  But broadcom.c is
    already in Makefile.inc, now building will fail because the linker gets
    broadcom_init() twice.
    Undo the change to mainboard.c but keep the change to broadcom.c.
    Change-Id: Ieccc098f477ffacccf4174056998034a220a9744
    Signed-off-by: Jens Rottmann <JRottmann at LiPPERTembedded.de>
 src/mainboard/amd/inagua/mainboard.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/amd/inagua/mainboard.c b/src/mainboard/amd/inagua/mainboard.c
index 7e9f1d9..dc23007 100644
--- a/src/mainboard/amd/inagua/mainboard.c
+++ b/src/mainboard/amd/inagua/mainboard.c
@@ -26,8 +26,8 @@
 #include <device/pci_def.h>
 #include <southbridge/amd/sb800/sb800.h>
 #include "SBPLATFORM.h" 	/* Platfrom Specific Definitions */
-// #include "broadcom.c"	/* broadcom_init() */
+void broadcom_init(void);
 void set_pcie_reset(void);
 void set_pcie_dereset(void);

More information about the coreboot-gerrit mailing list