[coreboot-gerrit] Patch merged into coreboot/master: b39ba2e lynxpoint: Basic configuration of SerialIO devices

gerrit at coreboot.org gerrit at coreboot.org
Mon Apr 1 23:28:53 CEST 2013

the following patch was just integrated into master:
commit b39ba2efcfb0da48c8e7719d1c8db037b567a8bc
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Fri Mar 22 11:21:14 2013 -0700

    lynxpoint: Basic configuration of SerialIO devices
    This adds configuration of SerialIO devices in the Lynxpoint-LP
    chipset.  This includes DMA, I2C, SPI, UART, and SDIO controllers.
    There is assorted magic setup necessary for the devices and
    while it is similar for each device there are subtle differences
    in some register settings.
    These devices must be put into "ACPI Mode" in order to take
    advantage of S0ix.  When in ACPI mode the allocated PCI BARs
    must be passed to ACPI so it can be relayed to the OS.  When
    the devices are in ACPI mode BAR0+BAR1 is saved into ACPI NVS
    and then updated and returned when the OS calls _CRS.
    Note that is is not entirely complete yet.  We need to update
    the IASL compiler in our build environment to support ACPI 5.0
    in order to be able to pass the FixedDMA entries to the kernel.
    There are also no ACPI methods defined yet to do D0->D3->D0
    transitions for actually entering/exiting S0ix states.
    This is hard to test right now because our kernel does not support
    any of these devices in ACPI mode.  I was able to build and test
    the upstream bleeding-edge branch of the linux-pm git tree.  With
    that tree I was able to enumerate and load the driver for the
    DesignWare I2C driver and attempt to probe the I2C bus -- although
    there are no devices attatched.
    I am also able to see the resources from ACPI in /proc/iomem get
    reserved properly in the kernel.
    Change-Id: Ie311addd6a25f3b7edf3388fe68c1cd691a0a500
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: http://review.coreboot.org/2971
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Fri Mar 29 23:36:18 2013, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Mon Apr  1 23:28:51 2013, giving +2
See http://review.coreboot.org/2971 for details.


More information about the coreboot-gerrit mailing list