[coreboot-gerrit] Patch merged into coreboot/master: af3158c lynxpoint: split clearing and enabling of smm

gerrit at coreboot.org gerrit at coreboot.org
Mon Apr 1 23:24:41 CEST 2013

the following patch was just integrated into master:
commit af3158c0cfd6034bbdc42a0488382c4be1a7a388
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed Mar 27 20:57:28 2013 -0500

    lynxpoint: split clearing and enabling of smm
    Previously southbridge_smm_init() was provided that did both
    the clearing of the SMM state and enabling SMIs. This is
    troublesome in how haswell machines bring up the APs. The BSP
    enters SMM once to determine if parallel SMM relocation is possible.
    If it is possible the BSP releases the APs to do SMM relocation.
    Normally, after the APs complete the SMM relocation, the BSP would then
    re-enter the relocation handler to relocate its own SMM space.
    However, because SMIs were previously enabled it is possible for an SMI
    event to occur before the APs are complete or have entered the
    relocation handler. This is bad because the BSP will turn off parallel
    SMM save state. Additionally, this is a problem because the relocation
    handler is not written to handle regular SMIs which can cause an
    SMI storm which effectively looks like a hung machine. Correct these
    issues by turning on SMIs after all the SMM relocation has occurred.
    Change-Id: Id4f07553b110b9664d51d2e670a14e6617591500
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/2977
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Sat Mar 30 01:02:43 2013, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Mon Apr  1 23:24:31 2013, giving +2
See http://review.coreboot.org/2977 for details.


More information about the coreboot-gerrit mailing list