[coreboot-gerrit] Patch merged into coreboot/master: 9ebd8ea inteltool: Allow to override Makefile variables

gerrit at coreboot.org gerrit at coreboot.org
Mon Apr 1 22:40:46 CEST 2013


the following patch was just integrated into master:
commit 9ebd8ea7cfd379cca56a2c48324bdfbe52ff6bab
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sun Mar 31 22:15:43 2013 +0200

    inteltool: Allow to override Makefile variables
    
    Allow to override the variables `CC`, `INSTALL`, `PREFIX`,
    `CFLAGS` and `LDFLAGS`. Though append `-lpci -lz` to `LDFLAGS`.
    
    This way for example a different compiler can easily be used.
    
        CC=clang make
    
    As a side note, Clang in contrast to GCC does *not* issue the
    following warnings.
    
        $ clang --version
        Debian clang version 3.2-1~exp6 (tags/RELEASE_32/final) (based on LLVM 3.2)
        Target: i386-pc-linux-gnu
        Thread model: posix
        $ gcc --version
        gcc-4.7.real (Debian 4.7.2-15) 4.7.2
        Copyright (C) 2012 Free Software Foundation, Inc.
        This is free software; see the source for copying conditions.  There is NO
        warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
        $ make
        […]
        amb.c: In function ‘amb_read_config32’:
        amb.c:31:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
        amb.c:31:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
        amb.c: In function ‘amb_read_config16’:
        amb.c:45:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
        amb.c:45:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
        amb.c: In function ‘amb_read_config8’:
        amb.c:60:22: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
        amb.c:60:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
        […]
    
    These are only shown under 32-bit and not 64-bit
    
        $ uname -m
        i686
    
    and are going to be fixed in a separate patch.
    
    Change-Id: Id75dea081ecb35390f283520a7e5dce520f4c98d
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/2996
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>

Build-Tested: build bot (Jenkins) at Mon Apr  1 21:50:59 2013, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer at coreboot.org> at Mon Apr  1 22:40:44 2013, giving +2
See http://review.coreboot.org/2996 for details.

-gerrit



More information about the coreboot-gerrit mailing list