Re: [SeaBIOS] [PATCH v2 1/1] SeaVGABios/cbvga: Fix bpp for coreboot framebuffer

Sept. 19, 2018
3:40 a.m.
On Tue, Sep 11, 2018 at 09:29:39PM -0500, Matt DeVillier wrote:
Commit 4b42cc4 [SeaVGABios/cbvga: Advertise correct pixel format] neglected to wrap the cbfb mask size components in GET_FARVAR(), which resulted in a bogus value for bpp, breaking output on most/all devices. Fix this by adding GET_FARVAR() as appropriate.
Additionally, some newer ChromeOS devices still fail even with this fix, so fall back to using the coreboot reported bit depth if the calculated valid is invalid.
Thanks. I committed this change. -Kevin
2485
Age (days ago)
2485
Last active (days ago)
0 comments
1 participants
participants (1)
-
Kevin O'Connor