Re: [SeaBIOS] Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)
On Wed, Dec 16, 2009 at 03:52:34PM +0200, Michael S. Tsirkin wrote:
I am mostly concerned with migrating between qemu versions with different roms, while guest was in the middle of running ROM. This might be solved if we migrated ROM content together with the device and put some padding in ROM content so that size can be kept constant.
SeaBIOS will always copy the roms into the 0xc0000-0xf0000 memory area (regardless of CONFIG_OPTIONROMS_DEPLOYED). So, if one migrates a machine while running a rom, the memory holding the rom should get migrated with everything else.
-Kevin
On Wed, Dec 16, 2009 at 09:12:21AM -0500, Kevin O'Connor wrote:
On Wed, Dec 16, 2009 at 03:52:34PM +0200, Michael S. Tsirkin wrote:
I am mostly concerned with migrating between qemu versions with different roms, while guest was in the middle of running ROM. This might be solved if we migrated ROM content together with the device and put some padding in ROM content so that size can be kept constant.
SeaBIOS will always copy the roms into the 0xc0000-0xf0000 memory area (regardless of CONFIG_OPTIONROMS_DEPLOYED). So, if one migrates a machine while running a rom, the memory holding the rom should get migrated with everything else.
-Kevin
Ah, cool. We still have the issue of migrating while ROM is being read, but this bug existed already.
On Wed, Dec 16, 2009 at 04:17:11PM +0200, Gleb Natapov wrote:
On Wed, Dec 16, 2009 at 09:12:21AM -0500, Kevin O'Connor wrote:
On Wed, Dec 16, 2009 at 03:52:34PM +0200, Michael S. Tsirkin wrote:
I am mostly concerned with migrating between qemu versions with different roms, while guest was in the middle of running ROM. This might be solved if we migrated ROM content together with the device and put some padding in ROM content so that size can be kept constant.
SeaBIOS will always copy the roms into the 0xc0000-0xf0000 memory area (regardless of CONFIG_OPTIONROMS_DEPLOYED). So, if one migrates a machine while running a rom, the memory holding the rom should get migrated with everything else.
Yes, but if migration happens in the middle of the copying...
Yes. This is not a new bug though.
-- Gleb.
On Wed, Dec 16, 2009 at 09:12:21AM -0500, Kevin O'Connor wrote:
On Wed, Dec 16, 2009 at 03:52:34PM +0200, Michael S. Tsirkin wrote:
I am mostly concerned with migrating between qemu versions with different roms, while guest was in the middle of running ROM. This might be solved if we migrated ROM content together with the device and put some padding in ROM content so that size can be kept constant.
SeaBIOS will always copy the roms into the 0xc0000-0xf0000 memory area (regardless of CONFIG_OPTIONROMS_DEPLOYED). So, if one migrates a machine while running a rom, the memory holding the rom should get migrated with everything else.
Yes, but if migration happens in the middle of the copying...
-- Gleb.
On Wed, Dec 16, 2009 at 04:15:16PM +0200, Michael S. Tsirkin wrote:
On Wed, Dec 16, 2009 at 04:17:11PM +0200, Gleb Natapov wrote:
On Wed, Dec 16, 2009 at 09:12:21AM -0500, Kevin O'Connor wrote:
On Wed, Dec 16, 2009 at 03:52:34PM +0200, Michael S. Tsirkin wrote:
I am mostly concerned with migrating between qemu versions with different roms, while guest was in the middle of running ROM. This might be solved if we migrated ROM content together with the device and put some padding in ROM content so that size can be kept constant.
SeaBIOS will always copy the roms into the 0xc0000-0xf0000 memory area (regardless of CONFIG_OPTIONROMS_DEPLOYED). So, if one migrates a machine while running a rom, the memory holding the rom should get migrated with everything else.
Yes, but if migration happens in the middle of the copying...
Yes. This is not a new bug though.
How so?
-- Gleb.
On Wed, Dec 16, 2009 at 04:18:49PM +0200, Gleb Natapov wrote:
On Wed, Dec 16, 2009 at 04:15:16PM +0200, Michael S. Tsirkin wrote:
On Wed, Dec 16, 2009 at 04:17:11PM +0200, Gleb Natapov wrote:
On Wed, Dec 16, 2009 at 09:12:21AM -0500, Kevin O'Connor wrote:
On Wed, Dec 16, 2009 at 03:52:34PM +0200, Michael S. Tsirkin wrote:
I am mostly concerned with migrating between qemu versions with different roms, while guest was in the middle of running ROM. This might be solved if we migrated ROM content together with the device and put some padding in ROM content so that size can be kept constant.
SeaBIOS will always copy the roms into the 0xc0000-0xf0000 memory area (regardless of CONFIG_OPTIONROMS_DEPLOYED). So, if one migrates a machine while running a rom, the memory holding the rom should get migrated with everything else.
Yes, but if migration happens in the middle of the copying...
Yes. This is not a new bug though.
How so?
BIOS already reads roms from devices, does it not? If we migrate in the middle of this process to a device with a different ROM, tough.
-- Gleb.
On Wed, Dec 16, 2009 at 04:28:49PM +0200, Gleb Natapov wrote:
On Wed, Dec 16, 2009 at 04:24:59PM +0200, Michael S. Tsirkin wrote:
On Wed, Dec 16, 2009 at 04:18:49PM +0200, Gleb Natapov wrote:
On Wed, Dec 16, 2009 at 04:15:16PM +0200, Michael S. Tsirkin wrote:
On Wed, Dec 16, 2009 at 04:17:11PM +0200, Gleb Natapov wrote:
On Wed, Dec 16, 2009 at 09:12:21AM -0500, Kevin O'Connor wrote:
On Wed, Dec 16, 2009 at 03:52:34PM +0200, Michael S. Tsirkin wrote: > I am mostly concerned with migrating between qemu versions with > different roms, while guest was in the middle of running ROM. > This might be solved if we migrated ROM content together with > the device and put some padding in ROM content so that > size can be kept constant.
SeaBIOS will always copy the roms into the 0xc0000-0xf0000 memory area (regardless of CONFIG_OPTIONROMS_DEPLOYED). So, if one migrates a machine while running a rom, the memory holding the rom should get migrated with everything else.
Yes, but if migration happens in the middle of the copying...
Yes. This is not a new bug though.
How so?
BIOS already reads roms from devices, does it not?
No it doesn't.
Oh, you are right, we do this on device init.
If we migrate in the middle of this process to a device with a different ROM, tough.
-- Gleb.
-- Gleb.
On Wed, Dec 16, 2009 at 04:24:59PM +0200, Michael S. Tsirkin wrote:
On Wed, Dec 16, 2009 at 04:18:49PM +0200, Gleb Natapov wrote:
On Wed, Dec 16, 2009 at 04:15:16PM +0200, Michael S. Tsirkin wrote:
On Wed, Dec 16, 2009 at 04:17:11PM +0200, Gleb Natapov wrote:
On Wed, Dec 16, 2009 at 09:12:21AM -0500, Kevin O'Connor wrote:
On Wed, Dec 16, 2009 at 03:52:34PM +0200, Michael S. Tsirkin wrote:
I am mostly concerned with migrating between qemu versions with different roms, while guest was in the middle of running ROM. This might be solved if we migrated ROM content together with the device and put some padding in ROM content so that size can be kept constant.
SeaBIOS will always copy the roms into the 0xc0000-0xf0000 memory area (regardless of CONFIG_OPTIONROMS_DEPLOYED). So, if one migrates a machine while running a rom, the memory holding the rom should get migrated with everything else.
Yes, but if migration happens in the middle of the copying...
Yes. This is not a new bug though.
How so?
BIOS already reads roms from devices, does it not?
No it doesn't.
If we migrate in the middle of this process to a device with a different ROM, tough.
-- Gleb.
-- Gleb.
-
Gleb Natapov -
Kevin O'Connor -
Michael S. Tsirkin