Re: [SeaBIOS] [PATCH] Don't enable thread preemption during S3 resume vga option rom execution.

[Paul Menzel]

Dear Kevin,


thank you for the patch.


Am Freitag, den 30.05.2014, 21:47 -0400 schrieb Kevin O'Connor:
> Signed-off-by: Kevin O'Connor <[e-mail]>
> ---
>  src/stacks.c | 
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/stacks.c b/src/stacks.c
> index 6bcb319..beccc0f 100644
> --- a/src/stacks.c
> +++ b/src/stacks.c
> @@ -287,7 +287,7 @@ thread_init(void)
>  int
>  threads_during_optionroms(void)
>  {
> -    return CONFIG_THREADS && ThreadControl == 2;
> +    return CONFIG_THREADS && ThreadControl == 2 && in_post();
>  }
>
> // Switch to next thread stack.

What problem did it cause and on what systems?


Thanks,

Paul

[PATCH] Don't enable thread preemption during S3 resume vga option rom execution.

[Kevin O'Connor]

On Sat, May 31, 2014 at 11:32:39AM +0200, Paul Menzel wrote:
> What problem did it cause and on what systems?

I'm not aware of this causing a problem on any system.  The
combination of "etc/threads"==2 (was CONFIG_THREAD_OPTIONROMS) and
"etc/s3-resume-vga-init"==1 is likely very rare.

With the above combination of options, on an S3 resume event and on
systems that use SeaBIOS to facilitate an S3 resume, the vga rom would
be executed and currently would be executed with the 1Khz RTC timer
interrupt enabled.  Enabling the timer isn't necessarily wrong, but it
has no value and it's not a good idea to mess with more hardware than
required during an S3 resume.

-Kevin