New iasl generate .lst as 'number: ' instead of 'number....', then acpi_extrace.py fails to extract any useful information, building fails.
Signed-off-by: Bo Yang boyang@suse.com --- Makefile | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile index f28d86c..e87210b 100644 --- a/Makefile +++ b/Makefile @@ -217,6 +217,7 @@ $(OUT)%.hex: src/%.dsl ./tools/acpi_extract_preprocess.py ./tools/acpi_extract.p $(Q)cpp -P $< > $(OUT)$*.dsl.i.orig $(Q)$(PYTHON) ./tools/acpi_extract_preprocess.py $(OUT)$*.dsl.i.orig > $(OUT)$*.dsl.i $(Q)$(IASL) $(call iasl-option,$(IASL),-Pn,) -vs -l -tc -p $(OUT)$* $(OUT)$*.dsl.i + $(Q)sed -i 's/^( *[0-9A-Fa-f]+): /\1..../' $(OUT)$*.lst $(Q)$(PYTHON) ./tools/acpi_extract.py $(OUT)$*.lst > $(OUT)$*.off $(Q)cat $(OUT)$*.off > $@
On Thu, Jan 24, 2013 at 09:49:06PM +0800, Bo Yang wrote:
New iasl generate .lst as 'number: ' instead of 'number....', then acpi_extrace.py fails to extract any useful information, building fails.
Thanks. However, I don't think we should introduce a dependency on sed to the build. If the acpi_extract python script isn't parsing correctly it should be fixed instead of introducing another build component.
-Kevin
On 01/26/2013 12:49 AM, Kevin O'Connor wrote:
On Thu, Jan 24, 2013 at 09:49:06PM +0800, Bo Yang wrote:
New iasl generate .lst as 'number: ' instead of 'number....', then acpi_extrace.py fails to extract any useful information, building fails.
Thanks. However, I don't think we should introduce a dependency on sed to the build. If the acpi_extract python script isn't parsing correctly it should be fixed instead of introducing another build component.
Yes. We can fix it in acpi_extract.py. The question is how to do it.
Reformat .lst with python instead of sed?
OR
add some if directive in python like this: if (iasl version > xxxx) { parse .lst in format "number: " } else { parse .lst in format "number...." }
which way to go?
-Kevin
-
Bo Yang -
Kevin O'Connor