git master build failure

[Gerd Hoffmann]

Hi,

$subject says all.

  Linking out/rom32seg.o
out/code32seg.o: In function `debug_putc':
/home/kraxel/projects/seabios/src/output.c:42: undefined reference to
`qemu_debug_putc'
/home/kraxel/projects/seabios/src/output.c:45: undefined reference to
`serial_debug_putc'
out/code32seg.o: In function `debug_flush':
/home/kraxel/projects/seabios/src/output.c:52: undefined reference to
`serial_debug_flush'
make: *** [out/rom32seg.o] Error 1

Config attached.  Happens only when configured for coreboot, qemu builds
do just fine.  Can't spot an obvious reason for the build failure
though.

cheers,
  Gerd

[Laszlo Ersek]

On 12/05/13 11:04, Gerd Hoffmann wrote:
> Hi,
>
> $subject says all.
>
> Linking out/rom32seg.o
> out/code32seg.o: In function `debug_putc':
> /home/kraxel/projects/seabios/src/output.c:42: undefined reference to
> `qemu_debug_putc'
> /home/kraxel/projects/seabios/src/output.c:45: undefined reference to
> `serial_debug_putc'
> out/code32seg.o: In function `debug_flush':
> /home/kraxel/projects/seabios/src/output.c:52: undefined reference to
> `serial_debug_flush'
> make: *** [out/rom32seg.o] Error 1
>
> Config attached.  Happens only when configured for coreboot, qemu builds
> do just fine.  Can't spot an obvious reason for the build failure
> though.

SRC32SEG doesn't contain "hw/serialio.c".

$(OUT)code32seg.o: $(OUT)autoconf.h $(patsubst %.c,
$(OUT)src/%.o,$(SRC32SEG)) ; $(call whole-compile, $(CFLAGS32SEG),
$(addprefix src/, $(SRC32SEG)),$@)

  Compiling whole program out/code32seg.o
printf '#include "/home/lacos/src/upstream/seabios/src/string.c"\n
#include "/home/lacos/src/upstream/seabios/src/output.c"\n #include
"/home/lacos/src/upstream/seabios/src/pcibios.c"\n #include
"/home/lacos/src/upstream/seabios/src/apm.c"\n #include
"/home/lacos/src/upstream/seabios/src/stacks.c"\n #include
"/home/lacos/src/upstream/seabios/src/hw/pci.c"\n' > out/code32seg.o.tmp.c

nm out/code32seg.o

         U qemu_debug_putc
         U serial_debug_flush
         U serial_debug_putc

Laszlo

[Gerd Hoffmann]

> SRC32SEG doesn't contain "hw/serialio.c".

Ah, that one is NOT filled from SRCBOTH.  That explains it ...
I'll push a build fix in a minute.

thanks,
  Gerd

[Kevin O'Connor]

On Thu, Dec 05, 2013 at 01:30:05PM +0100, Gerd Hoffmann wrote:
> > SRC32SEG doesn't contain "hw/serialio.c".
>
> Ah, that one is NOT filled from SRCBOTH.  That explains it ...
> I'll push a build fix in a minute.

Thanks - I missed that one.

-Kevin