Thanks for the detailed comment Laszlo,
Indeed my e-mail has changed and I only received replies to the commits where I added this new mail in the S-o-b section, should of added in all of them.
So as you said it, the problem was actually in using qfw_cfg_get_u32 which assumes the value is encoded LE and has an additional le32_to_cpu, should have used qfw_cfg_get directly like qfw_cfg_get_file does.
Regarding qfw_cfg_get_file - I wrote this code when this function did not exist yet, I think it was added 6 months ago. In any case, I will use it instead.
Thanks for this.
I will resubmit this entire commit series: * I will only change code in the last commit (tests) * I will remove a comment which is now not true anymore * I will add my new email in S-o-b
On Wed, Oct 16, 2019 at 3:29 PM Philippe Mathieu-Daudé email@example.com wrote:
On 10/16/19 2:14 PM, Laszlo Ersek wrote:
On 10/16/19 13:02, Sam Eiderman wrote:
Just wondering if the series is okay, as Gerd pointed out this series is a blocker for the corresponding changes in SeaBIOS for v 1.13
The QEMU series is still not merged, due to a bug in the last patch (namely, the test case, "hd-geo-test: Add tests for lchs override").
To my knowledge, SeaBIOS prefers to merge patches with the underlying QEMU patches merged first, so you'll likely have to fix that QEMU issue first.
I explained the bug in the QEMU test case here:
Yes, I was expecting a respin with find_fw_cfg_file() fixed per Laszlo detailed review.
(Alternative links to the same:
I've never received feedback to those messages, and I think you must have missed them.
FWIW, when I hit "Reply All" in that thread, you were on the "To:" list with:
Sam Eiderman firstname.lastname@example.org
but here you are present with
Sam Eiderman email@example.com
In addition, when I posted those messages, I got the following auto-response ("Undelivered Mail Returned to Sender"):
This is the mail system at host mx1.redhat.com.
I'm sorry to have to inform you that your message could not be delivered to one or more recipients. It's attached below.
For further assistance, please send mail to postmaster.
If you do so, please include this problem report. You can delete your own text from the attached returned message.
The mail system
firstname.lastname@example.org: host aserp2030.oracle.com[22.214.171.124] said: 550 5.1.1 Unknown recipient address. (in reply to RCPT TO command)
That explains it :)
I didn't know your new address, so I could only hope you'd find my feedback on qemu-devel.