[SeaBIOS] Re: [PATCH 1/5] lodepng: add lodepng

[Kevin O'Connor]

On Tue, Oct 29, 2019 at 06:42:21PM +0100, [e-mail] wrote:
> From: Daniel Maslowski
> Signed-off-by: Daniel Maslowski
>
> src/lodepng.c | 5983 +++++++++++++++++++++++++++++++++++++++++++++++++
>  src/lodepng.h | 1909 ++++++++++++++++
>  2 files changed, 7892 insertions(+)
>  create mode 100644 src/lodepng.c
>  create mode 100644 src/lodepng.h

Thanks.  FYI, we're planning to make a SeaBIOS release in mid
November.  So, new features would wait until after that release.

[...]
> --- /dev/null
> +++ b/src/lodepng.c
> @@ -0,0 +1,5983 @@
> +/*
> +LodePNG version 20181230
>
> +Copyright (c) 2005-2018 Lode Vandevenne
>
> +This software is provided 'as-is', without any express or implied
> +warranty. In no event will the authors be held liable for any damages
> +arising from the use of this software.
>
> +Permission is granted to anyone to use this software for any purpose,
> +including commercial applications, and to alter it and redistribute it
> +freely, subject to the following restrictions:
> The origin of this software must not be misrepresented; you must not
> claim that you wrote the original software. If you use this software
> in a product, an acknowledgment in the product documentation would be
> appreciated but is not required.
> Altered source versions must be plainly marked as such, and must not be
> misrepresented as being the original software.

It's not immediately obvious to me that this clause is compatible with
the LGPLv3.  Might be worthwhile to contact the upstream author and
explicitly ask if we can license it under LGPLv3.

Also, as a high-level comment, I think it would be preferable to make
as few modifications as possible to the upstream code.  For example,
if wrapper functions can be added (in a different c file) to avoid
changing the upstream code, then I think that would be preferable.

Cheers,
-Kevin