[SeaBIOS] Re: [PATCH 3/4] csm: Move pci_probe_devices() from InitializeYourself phase to PreparToBoot phase

[Paul Menzel]

Dear Bin,


Am 13.01.21 um 04:43 schrieb Gao, Bin:
> > Am 01.01.21 um 04:08 schrieb Bin Gao:

[…]
> > > +    // On physical hardware, some PCI devices are not detectable when
> > > +    // UEFI invokes our InitializeYourself() function. But they
> > > +    // are guaranteed to be available before UEFI invokes our
> > > +    // PreparToBoot() function.
> > > +    if (CONFIG_CSM && !CONFIG_QEMU_HARDWARE)
> > > +        pci_probe_devices();
> > > +
> > >        dprintf(3, "PrepareToBoot table %04x:%04x\n", regs->es, regs->bx);
> > >
> > > struct e820entry *p = (void *)csm_compat_table.E820Pointer;
> >
> > Why don’t we want to do the same for QEMU?
>
> This problem was only seen on physical hardware, so I wanted this
> fix to be applied only to physical hardware.

Yes, I understand, but less code “complexity” and having the same 
behavior on QEMU and real hardware is preferred. The maintainer Gerd 
replied yesterday. Did you get his reply (Message-ID: 
<[e-mail]>)?


Kind regards,

Paul