Kevin O'Connor firstname.lastname@example.org writes:
On Sat, Apr 30, 2011 at 10:19:25AM +0200, Sven Schnelle wrote:
There's no point in presenting a menu to the user if there's only one option to choose from. In that case skip this menu to save some waiting time during boot.
- /* If we have only one bootdevice,
skip interactive menu */
- if (!BootList->next)
BootList can be NULL here, so this isn't correct.
Ok, that should be easily fixable. It's of course wrong when there's no boot device at all ;)
In any case, I don't think making a special case for bootlist==1 is a good idea.
What's the reason you would not like to show the boot menu? Can you obtain the same by disabling CONFIG_BOOTMENU?
The only reason why i want to have this feature is because my Thinkpad spents the boot wait delay (default 2.5s) waiting for the user to press the F12 key, even though there's only one Boot device.
But if i insert a USB device, i want to have the menu - that's the reason why i've added this.