On Wed, Sep 26, 2018 at 07:03:37AM +0200, Gerd Hoffmann wrote:
Thanks. In general, looks fine to me.
Some minor comments:
If there's a read error or non-bootable device, shouldn't it just revert to the original description?
What about "empty" for drives not ready? Drop that too?
Well, if I saw:
4. DVD/CD [ata1-0: QEMU DVD-ROM ATAPI-4 DVD/CD] (empty)
I don't think I'd know what "empty" meant. Also, it's a little odd to have a C function sometimes return a dynamically allocated string and sometimes return a constant string. That said, I don't have a strong opinion.