Re: [SeaBIOS] [PATCH 1/3] Introduce serial_out(), serial_in() macros in serialio.c

[Kevin O'Connor]

On Fri, Dec 06, 2013 at 02:21:31PM +0000, David Woodhouse wrote:
> This will make it easier to abstract out the MMIO serial access. Even if
> that ends up in separate code which is a *copy* of this, at least they'll
> match.

Hi David,

I agree with this patch set.  I'd prefer a couple of minor changes -
use of inlines instead of macros/ifdefs and not using call32 for
debugging (for seavgabios and for fear of heisenbugs).  I can make
these changes if you wish.

-Kevin