On 6/14/10 3:07 AM, Kevin O'Connor wrote:
On Mon, Jun 14, 2010 at 12:52:36AM +0200, Stefan Reinauer wrote:
On 6/10/10 4:57 AM, Kevin O'Connor wrote:
One thing I did note is that the new file jpeg.c needs a copyright statement.
Still working on that.
Thanks. I think we can commit once we have that. (We can continue to improve the code once committed.)
A couple of random notes:
I like the separation of the code to "vga.c". However, I think I'd prefer something like "bootsplash.c" over "vga.c" - just so there is no confusion with the handle_10 vga callback implementation.
That's what I initially had and I changed it because it contains non-bootsplash specific code, too. (enable_vga_console) - If you think we should, I'll rename it back to bootsplash.c Or maybe vesa.c?
The changes to ulzma wont work. The malloc_X calls only work in POST, however ulzma can be called during boot (when seabios boots a payload). As far as I can tell it shouldn't be necessary though. SeaBIOS has a 24K stack (at 0x7000) for the "main thread" during both post and boot (each "thread" only has a 4K stack, but no thread calls ulzma).
ulzma may take more than those 15kb, and the code is theoretically able to find out how much it needs... Is there a malloc that could be used here?
Is there some documentation on what each malloc version does? It's quite confusing for beginners :-)
BTW, I think it should be straight forward to use this code in qemu also.
With some way to get hold of the jpg file, certainly.