On Wed, Dec 29, 2010 at 02:10:16PM -0500, Kevin O'Connor wrote:
On Wed, Dec 29, 2010 at 09:00:36PM +0200, Gleb Natapov wrote:
On Wed, Dec 29, 2010 at 12:46:45PM -0500, Kevin O'Connor wrote:
Some cleanups I came across while reviewing the boot code.
Gleb - patch 7 conflicts with your last patch - I hope it isn't a big deal to fixup though. (I'm still reviewing your last patch.)
The remaining patch is pretty independent. Should be very easy to rebase. Do you want me to do it?
It wouldn't hurt.
BTW, I was thinking of ways to try and simplify this code. What if we tried doing an exact string match for the device, but if that fails and a BDF is known for the device then do a prefix string search for the PCI device?
I don't see why this would be simpler. Also how can you do exact string match if BDF is not knows? You can't create device path without knowing BDF (well DF). My code works like OpenFirmware device path was designed to work: match device path one node at a time. This also allows for greater flexibility in qemu<->seabios interface.