On Mon, Jul 29, 2013 at 12:33:44PM +0300, Michael S. Tsirkin wrote:
This is a refactoring of patch PATCH v2: pci: load memory window setup from host.
Please note qemu merged the required interface already. Please review, and consider for release.
Changes from v3:
- fix bug causing windows to crash
- better debug output (when enabled)
Changes from v2:
- address comments by Kevin: avoid dynamic memory allocation refactor code to avoid special-casing loaded windows
- split out to two patch series
Changes from v1: - fix bug in 64 bit range check - address Kevin's comments: move file load into pciinit.c dont reorder initialization sizeof style fix
Michael S. Tsirkin (2): pciinit: refactor mem init code pci: load memory window setup from host
src/pciinit.c | 145 ++++++++++++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 121 insertions(+), 24 deletions(-)
-- MST
Kevin, could you please comment on this patchset?
I have some enhancement ideas like disabling devices selectively instead of a panic if we can't allocate memory, but it will be easier to build it on top.
SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios