On Tue, Feb 07, 2012 at 03:41:05PM +0100, Peter Stuge wrote:
Gerd Hoffmann wrote:
and I doubt anyone runs a cirrus bios on non-virtual hardware ...
If the Cirrus support is exclusively for virtual machines then at the very least please make that abundantly clear in the menuconfig oneline description.
Agreed. The description does say "QEMU", but I think we can expand on that in Kconfig. See the patch below.
From 197ea6c9b6cfff73e8613f32c2d86ea7b0a138cb Mon Sep 17 00:00:00 2001
From: Kevin O'Connor firstname.lastname@example.org Date: Tue, 7 Feb 2012 21:03:23 -0500 Subject: [PATCH] vgabios: Don't allow building of emulator vgaroms on coreboot.
If coreboot building is selected, don't allow the emulator based vga roms to be selected. Also, clarify the help text to make this clear.
Signed-off-by: Kevin O'Connor email@example.com --- vgasrc/Kconfig | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/vgasrc/Kconfig b/vgasrc/Kconfig index 881e9ec..c436aeb 100644 --- a/vgasrc/Kconfig +++ b/vgasrc/Kconfig @@ -11,19 +11,25 @@ menu "VGA ROM" Do not build a VGA BIOS.
config VGA_STANDARD_VGA + depends on !COREBOOT bool "Standard VGA" help - Build basic VGA BIOS support. + Build basic VGA BIOS support for use on emulators.
config VGA_CIRRUS + depends on !COREBOOT bool "QEMU Cirrus CLGD 54xx VGA BIOS" help - Build support for Cirrus VGA emulation. + Build support for Cirrus VGA emulation found on QEMU + and Bochs emulators. This is for emulators; it is not + intended for use on real Cirrus hardware.
config VGA_BOCHS + depends on !COREBOOT bool "Bochs DISPI interface VGA BIOS" help - Build support for Bochs DISPI interface. + Build support for Bochs DISPI interface found on QEMU + and Bochs emulators.
config VGA_GEODEGX2 bool "GeodeGX2 interface VGA BIOS"