On Thu, Oct 02, 2014 at 09:38:45PM +0200, Paolo Bonzini wrote:
Il 30/09/2014 20:38, Kevin O'Connor ha scritto:
- config CALL32_SMM
booldepends on USE_SMMdefault yI think it is a bit too early to make this the default.
Thanks for reviewing. The CONFIG_CALL32_SMM is currently only present to reduce the code size in non-qemu configs. It could be promoted to a user visible config choice, but I don't think many people would want to change it (it's currently only applicable to QEMU TCG anyway).
Also, it will be false on regular hardware---any plans to change this? Port 0xb2 is more or less universal, though enabling it requires chipset-specific initialization.
I think it would be useful to have this (or something similar) on kvm, coreboot, and csm. On coreboot, I imagine the coreboot code would have the smm handler and a coreboot table would pass in the port and equivalent of CALL32SMM_CMDID to activate the support in seabios. On kvm, I think the easiest would be to get psuedo smm support working in kvm. Not sure the best way to do it on CSM. I haven't looked at this in any depth though.
-Kevin