Re: [SeaBIOS] [PATCH V5 2/9] Provide ACPI SSDT table for TPM device + S3 resume support

[Andreas Niederl]

Hi,

On 07/06/2011 04:32 PM, Stefan Berger wrote:
> Index: seabios/src/acpi-tpm-ssdt.dsl
>
> --- /dev/null
> +++ seabios/src/acpi-tpm-ssdt.dsl
> @@ -0,0 +1,22 @@
> +DefinitionBlock (
> "acpi-tpm-ssdt.aml",// Output Filename
> "SSDT",             // Signature
> 0x01,               // SSDT Compliance Revision
> "BXPC",             // OEMID
> "BXSSDT",           // TABLE ID
> 0x1                 // OEM Revision
> )
>
> +{
> /* TPM with emulated TPM TIS interface */
> Device (TPM) {
>    Name (_HID, EisaID ("PNP0C31"))
>    Name (_CRS, ResourceTemplate ()
>    {
>            Memory32Fixed (ReadWrite, 0xFED40000, 0x00005000)
>            //IRQNoFlags () {11}
>    })
>    Method (_STA, 0, NotSerialized) {
>        Return (0x0F)
>    }
> }
>
> +}

For some reason the Linux tpm_tis driver does not recognize the device
(without using force=1) for me on Linux-2.6.33.
However, the driver modules are being loaded automatically, but without
registering a usable tpm device.

I'm no expert regarding ACPI but I noticed that the default SSDT
provided by SeaBIOS uses the Scope(_SB) header (in build_ssdt()).

Using this Scope(_SB) { ... } around the device entry in your SSDT, I've
been able to successfully use the TPM device detection.

Could you please include this header in your SSDT?

Regards,
Andreas