I’ve got a couple of “undelivered mail returned to sender” mails for Sam recently, but anyway...
- email@example.com + firstname.lastname@example.org
It doesn’t look like any caller actually passes a NULL @dev, so why not drop the @suffix part?
Just copied it from the bootindex implementation. I think the suffix part there was implemented specifically for fdc since the same device can have two suffixes (A and B). This is not relavant here, but I think we still need the suffix to create the device name for seabios to find.