[commit] r868 - trunk/openbios-devel/libopenbios

[repository service]

Author: mcayland
Date: Wed Sep 29 18:27:42 2010
New Revision: 868
URL: http://tracker.coreboot.org/trac/openbios/changeset/868

Log:
When DEBUG_CIF is defined, a serial message of the form "method(...) = "
is emitted by dump_service(). After successful execution the return value
and a linebreak are emitted by dump_return(). If however the method fails,
nothing is emitted, so that subsequent method calls end up in place of the
return value. Observed for getproplen with AIX.

Emit an error indication and a linebreak when DEBUG_CIF is defined.

Signed-off-by: Andreas Färber 
Signed-off-by: Mark Cave-Ayland

Modified:
   trunk/openbios-devel/libopenbios/client.c

Modified: trunk/openbios-devel/libopenbios/client.c
==============================================================================
--- trunk/openbios-devel/libopenbios/client.c	Tue Sep 28 20:59:47 2010	(r867)
+++ trunk/openbios-devel/libopenbios/client.c	Wed Sep 29 18:27:42 2010	(r868)
@@ -306,6 +306,10 @@
    	if( val == -1 )
    		printk("Unimplemented service %s ([%ld] -- [%ld])\n",
    		       pb->service, pb->nargs, pb->nret );
+#ifdef DEBUG_CIF
+		else
+			printk("ERROR!\n");
+#endif
    	return -1;
    }

[Andreas Färber]

Hi Mark,

Am 29.09.2010 um 18:27 schrieb repository service:
> Author: mcayland
> Date: Wed Sep 29 18:27:42 2010
> New Revision: 868
> URL: http://tracker.coreboot.org/trac/openbios/changeset/868
>
> Log:
> When DEBUG_CIF is defined, a serial message of the form "method(...)  
> = "
> is emitted by dump_service(). After successful execution the return  
> value
> and a linebreak are emitted by dump_return(). If however the method  
> fails,
> nothing is emitted, so that subsequent method calls end up in place  
> of the
> return value. Observed for getproplen with AIX.
>
> Emit an error indication and a linebreak when DEBUG_CIF is defined.
>
> Signed-off-by: Andreas Färber 
> Signed-off-by: Mark Cave-Ayland

Thanks for committing this!

Please remember to include the subject beyond the square brackets as  
well though, so that we get a readable one-line summary in Git.

Cheers,
Andreas

[Mark Cave-Ayland]

Andreas Färber wrote:
> Thanks for committing this!
>
> Please remember to include the subject beyond the square brackets as 
> well though, so that we get a readable one-line summary in Git.
>
> Cheers,
> Andreas

Ah sorry - I've just been using standard SVN comments as per the main 
repository. Blue/Stefan, should this be proper policy? Are we planning 
to switch to git at some point in the future?

ATB,

Mark.

[Stefan Reinauer]

On 9/30/10 11:46 AM, Mark Cave-Ayland wrote:
> Andreas Färber wrote:
> > Thanks for committing this!
> >
> > Please remember to include the subject beyond the square brackets as
> > well though, so that we get a readable one-line summary in Git.
> >
> > Cheers,
> > Andreas
>
> Ah sorry - I've just been using standard SVN comments as per the main
> repository. Blue/Stefan, should this be proper policy? Are we planning
> to switch to git at some point in the future?

No plans from my side...  I remember people didn't like the last DVCS'
(bitkeeper and GNU arch) too much, so I never considered git so far.
Not being much of a committer myself these days, I think if git solves
more problems for you guys than it creates, we should probably do it. In
that case we should move the repository to github or sourceforge, those
folks are much better at maintaining GIT repositories than I am.

Stefan

[Blue Swirl]

On Thu, Sep 30, 2010 at 5:40 PM, Stefan Reinauer  wrote:
> On 9/30/10 11:46 AM, Mark Cave-Ayland wrote:
> > Andreas Färber wrote:
> > > Thanks for committing this!
> > >
> > > Please remember to include the subject beyond the square brackets as
> > > well though, so that we get a readable one-line summary in Git.
> > >
> > > Cheers,
> > > Andreas
> >
> > Ah sorry - I've just been using standard SVN comments as per the main
> > repository. Blue/Stefan, should this be proper policy? Are we planning
> > to switch to git at some point in the future?
>
> No plans from my side...  I remember people didn't like the last DVCS'
> (bitkeeper and GNU arch) too much, so I never considered git so far.
> Not being much of a committer myself these days, I think if git solves
> more problems for you guys than it creates, we should probably do it. In
> that case we should move the repository to github or sourceforge, those
> folks are much better at maintaining GIT repositories than I am.

I'd prefer git, but with git-svn it doesn't matter much.