On 17.04.2009 5:41 Uhr, Asif Haswarey wrote:

Hi,

I have been using the tokenizer “toke” fcode-utils version 1.0.2 from:

http://www.openfirmware.info/FCODE_suite

I found out recently that toke does not support 64-bit constants.

It simply truncates the upper 32-bits.

Do we want 64-bit constant support?

Dear Äsif,

welcome back!

I think 64bit constants won't work on architectures with a 32bit cell size, so FCode using them will not be platform independent.

Nevertheless, if that's a feature that helps users of toke, we should definitely support it.

Can you give a usage example of 64bit constants? I would assume it's not BARs as those can be read from PCI config space?

What's the expected output of the tokenizer? put two 32bit constants on the stack, shift one by 32bit and OR them?

To be sure, we could add a command line option for enabling 64bit constants support and print a warning or an error in case it is not set. Does that sound reasonable?

Best regards,
Stefan

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info@coresystems.de  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866