[PATCH] CID1130004: Nesting level does not match indentation

[Stefan Reinauer]

CID1130004: Nesting level does not match indentation

Code that is meant to be executed conditionally may be executed unconditionally
In print_supported_boards_helper: The indentation of this code suggests it is
nested when it is not.

Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>

Index: print.c
===================================================================
--- print.c	(revision 1763)
+++ print.c	(working copy)
@@ -436,13 +436,14 @@
 		msg_ginfo("%s", b->name);
 		for (i = 0; i < maxboardlen - strlen(b->name); i++)
 			msg_ginfo(" ");
-			if (b->working == OK)
-				msg_ginfo("OK      ");
-			else if (b->working == NT)
-				msg_ginfo("NT      ");
-			else
-				msg_ginfo("BAD     ");
 
+		if (b->working == OK)
+			msg_ginfo("OK      ");
+		else if (b->working == NT)
+			msg_ginfo("NT      ");
+		else
+			msg_ginfo("BAD     ");
+
 		for (e = board_matches; e->vendor_name != NULL; e++) {
 			if (strcmp(e->vendor_name, b->vendor)
 			    || strcmp(e->board_name, b->name))

[PATCH] CID1130004: Nesting level does not match indentation

[Stefan Tauner]

On Tue, 19 Nov 2013 20:35:57 +0100
Stefan Reinauer <stefan.reinauer(a)coreboot.org> wrote:

  CID1130004: Nesting level does not match indentation
 
 Code that is meant to be executed conditionally may be executed unconditionally
 In print_supported_boards_helper: The indentation of this code suggests it is
 nested when it is not.
 
 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
 
 Index: print.c
 ===================================================================
 --- print.c	(revision 1763)
 +++ print.c	(working copy)
 @@ -436,13 +436,14 @@
  		msg_ginfo("%s", b->name);
  		for (i = 0; i < maxboardlen - strlen(b->name); i++)
  			msg_ginfo(" ");
 -			if (b->working == OK)
 -				msg_ginfo("OK      ");
 -			else if (b->working == NT)
 -				msg_ginfo("NT      ");
 -			else
 -				msg_ginfo("BAD     ");
  
 +		if (b->working == OK)
 +			msg_ginfo("OK      ");
 +		else if (b->working == NT)
 +			msg_ginfo("NT      ");
 +		else
 +			msg_ginfo("BAD     ");
 +
  		for (e = board_matches; e->vendor_name != NULL; e++) {
  			if (strcmp(e->vendor_name, b->vendor)
  			    || strcmp(e->board_name, b->name))
Acked-by: Stefan Tauner &lt;stefan.tauner(a)alumni.tuwien.ac.at&gt;
and committed in r1770, thanks!

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner