Re: [flashrom] [PATCH] Refine physical address mapping of flash chips.

[Stefan Tauner]

On Wed, 20 Aug 2014 01:15:43 +0200
Stefan Tauner  wrote:
> msg_pdbg2("Successfully mapped flash chip "%s" at physical address 0x%0*" PRIxPTR ".\n",
>   fill_flash->chip->name, PRIxPTR_WIDTH, fill_flash->physical_memory);

Forgot to remove these lines, please ignore.

[PATCH] Refine physical address mapping of flash chips.

[Carl-Daniel Hailfinger]

Am 20.08.2014 18:10 schrieb Stefan Tauner:
> On Wed, 20 Aug 2014 01:15:43 +0200
> Stefan Tauner  wrote:
> > msg_pdbg2("Successfully mapped flash chip "%s" at physical address 0x%0*" PRIxPTR ".\n",
> >   fill_flash->chip->name, PRIxPTR_WIDTH, fill_flash->physical_memory);
>
> Forgot to remove these lines, please ignore.

This patch is really great. Thanks!

As discussed in IRC, the lock info printing comment and the missing
error check for forced probe would benefit from fixing. With those
changes, this is

Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[PATCH] Refine physical address mapping of flash chips.

[Stefan Tauner]

On Sun, 31 Aug 2014 00:32:43 +0200
Carl-Daniel Hailfinger  wrote:
> Am 20.08.2014 18:10 schrieb Stefan Tauner:
> > On Wed, 20 Aug 2014 01:15:43 +0200
> > Stefan Tauner  wrote:
> > > msg_pdbg2("Successfully mapped flash chip "%s" at physical address 0x%0*" PRIxPTR ".\n",
> > >   fill_flash->chip->name, PRIxPTR_WIDTH, fill_flash->physical_memory);
> >
> > Forgot to remove these lines, please ignore.
>
> This patch is really great. Thanks!
>
> As discussed in IRC, the lock info printing comment and the missing
> error check for forced probe would benefit from fixing. With those
> changes, this is
>
> Acked-by: Carl-Daniel Hailfinger

Thanks, committed in r1847.