Re: [flashrom] [PATCH] Rename identifiers called 'byte' - flashrom

25 Feb 2010


      On 25.02.2010 11:50, Michael Karcher wrote:
...
Still fallout of adding "-Wshadow". Missed the ht1000 one
(chipset_enable is not compied on Windows where we had the collision
with "byte" last time) and the other occurrence is newly introduced.
Old libpci defines a global symbol called "byte" too.
Signed-off-by: Michael Karcher flashrom@mkarcher.dialup.fu-berlin.de
No objection from a technical POV, but I really dislike the name lpc_8a.
I don't have a good suggestion for a better variable name, though. Maybe
mcp_bustype?
Oh well.
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Regards,
Carl-Daniel
-- 
"I do consider assignment statements and pointer variables to be among
computer science's most valuable treasures."
-- Donald E. Knuth