[PATCH] Add a udev rules file for flashrom

[Uwe Hermann]

See patch.

Uwe.

[Carl-Daniel Hailfinger]

On 11.06.2010 01:13, Uwe Hermann wrote:
> Add a udev rules file for flashrom.
>
> This allows USB-based external programmers to be used by non-root users
> (which are in the 'plugdev' group). The file is to be installed by the
> distros into the proper place (not sure if this is distro-specific). On
> Debian the file will end up in /etc/udev/rules.d/z60_flashrom.rules.
>
> The following devices are listed so far:
> Buspirate
> Dediprog SF100
> DLP Design DLP-USB1232H
> FTDI FT4232H Mini-Module
>
> Signed-off-by: Uwe Hermann

The following Bus Pirate link may be better:
http://dangerousprototypes.com/2009/10/08/bus-pirate-raw-spi-mode/

Could you add a comment to the file which states the exact udev version
and Debian release? udev and associated rulesets change so fast that it
is unlikely the script will work as is on other machines.

Besides that, we should think about where to store this file. flashrom
source tree, wiki or somewhere else...

Regards,
Carl-Daniel

[Uwe Hermann]

On Fri, Jun 11, 2010 at 02:55:51AM +0200, Carl-Daniel Hailfinger wrote:
> The following Bus Pirate link may be better:
> http://dangerousprototypes.com/2009/10/08/bus-pirate-raw-spi-mode/

Updated.
> Could you add a comment to the file which states the exact udev version
> and Debian release? udev and associated rulesets change so fast that it
> is unlikely the script will work as is on other machines.

Done, udev 154, but I think any recent version will work.
> Besides that, we should think about where to store this file. flashrom
> source tree, wiki or somewhere else...

Definately source tree, yes.

Updated patch attached.

Uwe.

[Carl-Daniel Hailfinger]

On 11.06.2010 13:08, Uwe Hermann wrote:
> On Fri, Jun 11, 2010 at 02:55:51AM +0200, Carl-Daniel Hailfinger wrote:
> > The following Bus Pirate link may be better:
> > http://dangerousprototypes.com/2009/10/08/bus-pirate-raw-spi-mode/
>
> Updated.
> > Could you add a comment to the file which states the exact udev version
> > and Debian release? udev and associated rulesets change so fast that it
> > is unlikely the script will work as is on other machines.
>
> Done, udev 154, but I think any recent version will work.

Turns out the plugdev group mentioned in the rules is nonstandard and
probably won't work anywhere except Debian.
> > Besides that, we should think about where to store this file. flashrom
> > source tree, wiki or somewhere else...
>
> Definately source tree, yes.
>
> Updated patch attached.

Thanks. Could you add a comment to the udev file that it only works on
Debian and/or rename it to z60_flashrom_debian.rules?

Should we commit this to the main flashrom directory or to a new
directory tools/ or maybe scripts/ or helpers/?
I think tools/ is preferable, but I won't object to other solutions.

What do others think? We're starting a directory hierarchy here and
moving stuff around a few times is bad, so I'd like to get the location
finalized in a way that allows sensible future extension.

Side note: If we pick tools/, we can also place the MAC adjustment
scripts and some image extraction scripts there.

Once we have a decision on the final location of this script, this is
Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[Uwe Hermann]

On Sat, Jul 24, 2010 at 05:36:28PM +0200, Carl-Daniel Hailfinger wrote:
> Should we commit this to the main flashrom directory or to a new
> directory tools/ or maybe scripts/ or helpers/?
> I think tools/ is preferable, but I won't object to other solutions.

Put it into a util/ directory as per IRC discussion.

Also added a comment that "plugdev" may have to be changed on some
distros to whatever is suitable there.
> Acked-by: Carl-Daniel Hailfinger

Thanks, r1110.

I also added the new JTAGkey(2) device IDs for completeness.

Uwe.