Re: [flashrom] New programmer board "SPI_TT LPT" support - patch submission

[Stefan Tauner]

On Tue, 4 Aug 2015 11:12:08 +0300
Max  wrote:
> Hello, everybody, involved into flashrom!
>
> I'd implemented support for well known in Russia SPI_TT LPT programmer.
> Basically, it's only Byteblaster clone with changed pinout. So,
> modifications was pretty straIghtforward.
>
> In attach - modified "rayer_spi.c" from trunk branch.
> Hope, it will be useful for someone.

Hi Max,

thanks for your contribution! Please post a proper patch according to
our development guidelines next time:
https://www.flashrom.org/Development_Guidelines

I have prepared a patch as you suggested and even included an entry to
the manpage. However, I wonder if you have tested your file
successfully because the tested field was set to NT instead of OK.
Also, doesn't it need any enable routine like the byteblaster?

New programmer board "SPI_TT LPT" support - patch submission

[Max]

Hello, Stefan!

Actually, I doesn't real Linux C programmer - I just passed by. :)
So, I just tried to get into this area, but get very distracted by
wretchedness and inconvenience of Linux development tools. I don't think
there's will be next time. :) I just "threw patch away", hoping that this
programmer widely enough available and somebody, having proper skills,
finishes it. Seems to be, my thoughts was wrong, but till now I don't be
sad.
Now I surprised! Thank you for your precious time to finish this patch,
Stefan!

I marked them as untested because I think that my one working quick dirty
patch is not an reliable proof of testing.
It doesn't need any enable routine - it has no logic, no triggers/relay -
just resistors and buffer.

Best regards,
Max Arephin.

2016-02-21 20:45 GMT+03:00 Stefan Tauner 
:
> On Tue, 4 Aug 2015 11:12:08 +0300
> Max  wrote:
> > Hello, everybody, involved into flashrom!
> >
> > I'd implemented support for well known in Russia SPI_TT LPT programmer.
> > Basically, it's only Byteblaster clone with changed pinout. So,
> > modifications was pretty straIghtforward.
> >
> > In attach - modified "rayer_spi.c" from trunk branch.
> > Hope, it will be useful for someone.
>
> Hi Max,
>
> thanks for your contribution! Please post a proper patch according to
> our development guidelines next time:
> https://www.flashrom.org/Development_Guidelines
>
> I have prepared a patch as you suggested and even included an entry to
> the manpage. However, I wonder if you have tested your file
> successfully because the tested field was set to NT instead of OK.
> Also, doesn't it need any enable routine like the byteblaster?
> --
> Kind regards/Mit freundlichen Grüßen, Stefan Tauner