[PATCH] fix the DOS port problems

[Rudolf Marek]

Hi,

Attaching a patch which works around the valloc() issue in the DJGPP. 
Please apply before the flashrom 1.0.

In the meanwhile, it would be great if someone could test it too,
if needed I will distribute the executable for a test to Rayer (on CC).

I will also try to get some help on DJGPP list, as this issue happens 
even with the official RPMs of DJGPP 2.05.

Signed-off-by: Rudolf Marek

Fix the documentation and DOS port.

Update the DOS cross-compile documentation,
and workaround issue with valloc() with the
latest DJGPP.

Thanks
Rudolf

[Rudolf Marek]

Hi again,

Here is a small update: The valloc() issue exists for other users of DJGPP, but with the patch I developed flashrom
is not affected.

I'm attaching two patches, first is for the flashrom (fix_dos.patch) the only change from last time is 
fixed URL to the Pciutils-3.5.6.patch which someone needs to put on wiki. The old patch can be removed 
(http://flashrom.org/File:Pciutils.patch.gz) While at it, please also fix the "DOS" compilation page,
or just point to README, where are the latest information.

The second patch is a update for latest pciutils, it also fixes wrong endianess detection
I had in the last patch. The lspci.exe now prints everything correctly, even with human readable strings ;)
(if you put the pci.ids to :\share directory). I'm also disabling the interrupts while doing the 
PCI I/O, which I think is good idea. I will try to get Pciutils-3.5.6.patch patch into pciutils.

The signed-off-line is for fix_dos.patch, the Pciutils-3.5.6.patch has its own.

Signed-off-by: Rudolf Marek

Fix the documentation and DOS port.

Update the DOS cross-compile documentation,
and workaround issue with valloc() with the
latest DJGPP.

Thanks
Rudolf

[Nico Huber]

Hi Rudolf!

On 29.12.2017 21:49, Rudolf Marek wrote:
> I'm attaching two patches, first is for the flashrom (fix_dos.patch) the
> only change from last time is fixed URL to the Pciutils-3.5.6.patch
> which someone needs to put on wiki.

I've pushed your original patch to gerrit [1] you can update it there or
I'll do it later. I've also uploaded the pciutils patch to the wiki,
though gzipped, like the old one [2].

For build tests, I've added a Docker image for djgpp [3], your README
update was much helpful ;) I'll try to review your DOS patch later.
> The old patch can be removed
> (http://flashrom.org/File:Pciutils.patch.gz)

Hmm, are you sure it's not useful anymore? I'd leave it there otherwise,
because a lot of older README checkouts point to it oO

Nico

[1] https://review.coreboot.org/23039/
[2] https://flashrom.org/File:Pciutils-3.5.6.patch.gz
[3] https://review.coreboot.org/23042/

[Rudolf Marek]

Hi Nico,

Dne 29.12.2017 v 22:25 Nico Huber napsal(a):
> > The old patch can be removed
> > (http://flashrom.org/File:Pciutils.patch.gz)
>
> Hmm, are you sure it's not useful anymore? I'd leave it there otherwise,
> because a lot of older README checkouts point to it oO

Ok, lets leave it as is.

In the meanwhile the DJGPP/DOS patch was accepted to pciutils tree.

https://git.kernel.org/pub/scm/utils/pciutils/pciutils.git/commit/?id=5c5ce1...

Maybe we can just provide a link to that git or 3.5.7 once is out.

Thanks
Rudolf