Re: [flashrom] [PATCH] Board enable for ASUS P4SD-LA (HP OEM)

[Carl-Daniel Hailfinger]

Hi csh tmp,

I didn't see a response from you for Michael's patch for your P4SD-LA
(HP OEM) board.

On 24.04.2010 11:13, Michael Karcher wrote:
> This one was so easy that I didn't wait for a request.
>
> Signed-off-by: Michael Karcher

The patch is available at http://patchwork.coreboot.org/patch/1261/
Download link for the patch: http://patchwork.coreboot.org/patch/1261/raw/

Can you please test and tell us if it works?

Regards,
Carl-Daniel

[PATCH] Board enable for ASUS P4SD-LA (HP OEM)

[Carl-Daniel Hailfinger]

On 07.06.2010 16:46, Carl-Daniel Hailfinger wrote:
> Hi csh tmp,
>
> I didn't see a response from you for Michael's patch for your P4SD-LA
> (HP OEM) board.
>
> On 24.04.2010 11:13, Michael Karcher wrote:
> > This one was so easy that I didn't wait for a request.
> >
> > Signed-off-by: Michael Karcher
>
> The patch is available at http://patchwork.coreboot.org/patch/1261/
> Download link for the patch: http://patchwork.coreboot.org/patch/1261/raw/
>
> Can you please test and tell us if it works?

(No response in 3 months, please commit as NT)
Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[PATCH] Board enable for ASUS P4SD-LA (HP OEM)

[Michael Karcher]

Am Samstag, den 24.07.2010, 12:49 +0200 schrieb Carl-Daniel Hailfinger:
> > > Signed-off-by: Michael Karcher
>
> (No response in 3 months, please commit as NT)
> Acked-by: Carl-Daniel Hailfinger

Thanks! Committed as r1101.

Regards,
  Michael Karcher

[PATCH] Board enable for ASUS P4SD-LA (HP OEM)

[Idwer Vollering]

2010/7/24 Michael Karcher
> Am Samstag, den 24.07.2010, 12:49 +0200 schrieb Carl-Daniel Hailfinger:
> > > > Signed-off-by: Michael Karcher <[e-mail]
> >
> > (No response in 3 months, please commit as NT)
> > Acked-by: Carl-Daniel Hailfinger
>
> Thanks! Committed as r1101.

And that broke compilation:

cc -MMD -Os -Wall -Wshadow -Werror  -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_RAYER_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_NIC3COM=1' -D'CONFIG_SATASII=1'  -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICREALTEK=1' -D'CONFIG_BUSPIRATE_SPI=1'
-D'NEED_PCI=1' -D'HAVE_UTSNAME=1' -D'FLASHROM_VERSION="0.9.2-r1102"' -o
board_enable.o -c board_enable.c
cc1: warnings being treated as errors
board_enable.c:1697:2: error: initialization from incompatible pointer type
make: *** [board_enable.o] Error 1

---

Index: board_enable.c
===================================================================
--- board_enable.c      (revision 1102)
+++ board_enable.c      (working copy)
@@ -1320,7 +1320,7 @@
 /**
  * Suited for P4SD-LA (HP OEM): i865 + ICH5
  */
-static int intel_ich_gpio32_raise(const char *name)
+static int intel_ich_gpio32_raise(void)
 {
        return intel_ich_gpio_set(32, 1);
 }
> Regards,
>   Michael Karcher

Signed-off-by: Idwer Vollering
> flashrom mailing list
> [e-mail]
> http://www.flashrom.org/mailman/listinfo/flashrom

[PATCH] Board enable for ASUS P4SD-LA (HP OEM)

[Carl-Daniel Hailfinger]

On 24.07.2010 20:32, Idwer Vollering wrote:
> 2010/7/24 Michael Karcher
> > Thanks! Committed as r1101.
>
> And that broke compilation:
> [...]
>
> Signed-off-by: Idwer Vollering

Thanks for your patch.
Acked-by: Carl-Daniel Hailfinger 
and committed in r1103.

Regards,
Carl-Daniel