[PATCH] nicnatsemi.c: Typo. s/are apparently don't/apparently don't/

[Paul Menzel]

Signed-off-by: Paul Menzel 
---
 nicnatsemi.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/nicnatsemi.c b/nicnatsemi.c
index 1878f51..5f44677 100644
--- a/nicnatsemi.c
+++ b/nicnatsemi.c
@@ -60,7 +60,7 @@ void nicnatsemi_chip_writeb(uint8_t val, chipaddr addr)
    /*
     * The datasheet requires 32 bit accesses to this register, but it seems
     * that requirement might only apply if the register is memory mapped.
-	 * Bit 8-31 of this register are apparently don't care, and if this
+	 * Bit 8-31 of this register apparently don't care, and if this
     * register is I/O port mapped 8 bit accesses to the lowest byte of the
     * register seem to work fine. Due to that, we ignore the advice in the
     * data sheet.
@@ -74,7 +74,7 @@ uint8_t nicnatsemi_chip_readb(const chipaddr addr)
    /*
     * The datasheet requires 32 bit accesses to this register, but it seems
     * that requirement might only apply if the register is memory mapped.
-	 * Bit 8-31 of this register are apparently don't care, and if this
+	 * Bit 8-31 of this register apparently don't care, and if this
     * register is I/O port mapped 8 bit accesses to the lowest byte of the
     * register seem to work fine. Due to that, we ignore the advice in the
     * data sheet.

[Carl-Daniel Hailfinger]

On 12.06.2010 22:52, Paul Menzel wrote:
> Signed-off-by: Paul Menzel

Thanks for your patch.
> --- a/nicnatsemi.c
> +++ b/nicnatsemi.c
> @@ -60,7 +60,7 @@ void nicnatsemi_chip_writeb(uint8_t val, chipaddr addr)
>    /*
>     * The datasheet requires 32 bit accesses to this register, but it seems
>     * that requirement might only apply if the register is memory mapped.
> * Bit 8-31 of this register are apparently don't care, and if this
> * Bit 8-31 of this register apparently don't care, and if this
> register is I/O port mapped 8 bit accesses to the lowest byte of the
> register seem to work fine. Due to that, we ignore the advice in the
> data sheet.

"don't care" is used as a compound adjective and the verb in the
compound adjective is ignored in that case. Please see
http://en.wikipedia.org/wiki/Don%27t-care_(logic) for details. It is
possible to improve readability slightly with the following variant:

Bit 8-31 of this register are apparently don't-care bits, and...

Not sure if this is really better, and we probably should ask a native
speaker who works with hardware logic.

Regards,
Carl-Daniel

[Andrew Morgan]

On 12/06/10 22:28, Carl-Daniel Hailfinger wrote:
> On 12.06.2010 22:52, Paul Menzel wrote:
> > * Bit 8-31 of this register are apparently don't care, and if this
> > * Bit 8-31 of this register apparently don't care, and if this
>
> "don't care" is used as a compound adjective and the verb in the
> compound adjective is ignored in that case. Please see
> http://en.wikipedia.org/wiki/Don%27t-care_(logic) for details. It is
> possible to improve readability slightly with the following variant:
>
> Bit 8-31 of this register are apparently don't-care bits, and...
>
> Not sure if this is really better, and we probably should ask a native
> speaker who works with hardware logic.

I would be tempted to put:
are "don't care"
with the quotes, if it is quoting the datasheet?

[PATCH] nicnatsemi.c: Typo. s/are apparently don't/apparently don't/

[David Borg]

On 13 June 2010 00:06, Andrew Morgan  wrote:
> On 12/06/10 22:28, Carl-Daniel Hailfinger wrote:
> > On 12.06.2010 22:52, Paul Menzel wrote:
> > > * Bit 8-31 of this register are apparently don't care, and if this
> > > * Bit 8-31 of this register apparently don't care, and if this
> >
> > "don't care" is used as a compound adjective and the verb in the
> > compound adjective is ignored in that case. Please see
> > http://en.wikipedia.org/wiki/Don%27t-care_(logic) for details. It is
> > possible to improve readability slightly with the following variant:
> >
> > Bit 8-31 of this register are apparently don't-care bits, and...

I think just saying:

* Bits 8-31 of this register are apparently don't care, ...

should be enough. Just use the plural as a range of bits is being specified.

Attached patch does just that, and fixes a missing comma on the following line.
> > Not sure if this is really better, and we probably should ask a native
> > speaker who works with hardware logic.

I'm not a native speaker, but English is my second language :P
> I would be tempted to put:
> are "don't care"
> with the quotes, if it is quoting the datasheet?
>
> Andrew.

I don't think that's necessary.

Signed-off-by: David Borg 
Acked-by: David Borg  (trivial)

[Uwe Hermann]

On Sat, Aug 07, 2010 at 02:51:09PM +0200, David Borg wrote:
> I think just saying:
> Bits 8-31 of this register are apparently don't care, ...
>
> should be enough. Just use the plural as a range of bits is being specified.
> Signed-off-by: David Borg

Thanks, r1135.

Uwe.