Re: [flashrom] Patch for LE25FU106B

[Nico Huber]

Hi Raven,

we are about to merge your patches but this one raises questions.

On 6/7/18 1:22 PM, The_Raven Raven wrote:
> Hi
> This patch add support for LE25FU106B chip.
> Tested and works:
> - Probe
> - Read
> - Write
> - All erase functions

How did you test the erase functions? The log you attached only showed
the 2KiB erase being used. It doesn't provide evidence that the instruc-
tion doesn't erase more than 2KiB. I'm asking because the datasheet I'm
reading states it should be 4KiB.

Nico

Patch for LE25FU106B

[Nico Huber]

Hi again,

more comments here: https://review.coreboot.org/28813
Would be nice if you'd join us on Gerrit [1].

Nico

[1] https://coreboot.org/Git#Gerrit