Re: [flashrom] [PATCH] Remove sharplhf00l04.c
Am 20.06.2011 01:13 schrieb Michael Karcher:
The currently unreferenced function in sharplhf00l04.c does a standard FWH block protection reset (writes 0 to the protection register) and a standard FWH block erase.
The locking blocks of the FWH block lock cover 128KB areas, and thats the only thing page_size is used for in the functions referenced in the LHF00L04 entry.
My datasheet talks about 8 kB sectors and 64 kB blocks in "Figure 3. Memory Map", but "Table 8. FWH Flash Registers Configuration Map" only mentions registers for the 8 kB sectors in the top 64 kB block explicitly. "Table 8" also mentions "XX002H Whole Block Lock Register" as generic placeholder, and AFAICS those two X mean you have one block lock register for each of the 15 bottom 64 kB blocks and one for each of the 8 top 8 kB sectors. That also means the 82802ab unlocking as is can't be used. I was unable to find any 128 kB reference in my datasheet, so I'm going to Nack that part.
Finally, this adds a comment that there are non-volatile (flash memory) lock bits for 8 sectors in the last 64KB. They are write-only and clearable at once. Readback seems unsupported.
I have a slightly different interpretation of the datasheet (see above), so I'm not sure how to proceed.
Signed-off-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>
Killing sharplhf00l04.c is a good thing, though, so that part is Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Regards, Carl-Daniel -- http://www.hailfinger.org/
Am Montag, den 20.06.2011, 01:59 +0200 schrieb Carl-Daniel Hailfinger:
The locking blocks of the FWH block lock cover 128KB areas, and thats the only thing page_size is used for in the functions referenced in the LHF00L04 entry. My datasheet talks about 8 kB sectors and 64 kB blocks in "Figure 3. Memory Map", but "Table 8. FWH Flash Registers Configuration Map" only mentions registers for the 8 kB sectors in the top 64 kB block explicitly. "Table 8" also mentions "XX002H Whole Block Lock Register" as generic placeholder, and AFAICS those two X mean you have one block lock register for each of the 15 bottom 64 kB blocks and one for each of the 8 top 8 kB sectors. That also means the 82802ab unlocking as is can't be used.
I'm looking at Sharp Spec No. FM037006, Issue Date: June 18, 2003 You are right that the erase block size is 64kB as shown e.g. in figure 3. This is not touched by my patch, though. Taking a close look at table 8, I read it as: The whole block locking bit (affecting the whole flash chip area 0-1M) is possibly accessible each 4KB, but no matter what address you use, you get to the same single "master write protect" bit. This bit is located at data bit 1. On the other hand, the bits locking only parts of the flash chip are mentioned in the lines below that, with a "Protected address range of 128KB each and addresses of F0002h, F2002h, F4002h, F6002h, F8002h, FA002h, FC002h and FE002h. These 8 "sector-specific" lock bits are located at bit 0. Nowhere this table mentions anything about bits affecting only 8KB sized areas. On the other hand, text of the data sheet nowhere mentions the sectorwise locking - it is just in the table. I have no idea how to read that. Regards, Michael Karcher
Am 20.06.2011 07:42 schrieb Michael Karcher:
Am Montag, den 20.06.2011, 01:59 +0200 schrieb Carl-Daniel Hailfinger:
The locking blocks of the FWH block lock cover 128KB areas, and thats the only thing page_size is used for in the functions referenced in the LHF00L04 entry.
My datasheet talks about 8 kB sectors and 64 kB blocks in "Figure 3. Memory Map", but "Table 8. FWH Flash Registers Configuration Map" only mentions registers for the 8 kB sectors in the top 64 kB block explicitly. "Table 8" also mentions "XX002H Whole Block Lock Register" as generic placeholder, and AFAICS those two X mean you have one block lock register for each of the 15 bottom 64 kB blocks and one for each of the 8 top 8 kB sectors. That also means the 82802ab unlocking as is can't be used.
I'm looking at Sharp Spec No. FM037006, Issue Date: June 18, 2003
Same here.
You are right that the erase block size is 64kB as shown e.g. in figure 3. This is not touched by my patch, though. Taking a close look at table 8, I read it as: The whole block locking bit (affecting the whole flash chip area 0-1M) is possibly accessible each 4KB, but no matter what address you use, you get to the same single "master write protect" bit. This bit is located at data bit 1. On the other hand, the bits locking only parts of the flash chip are mentioned in the lines below that, with a "Protected address range of 128KB
My datasheet (same date, same number) does not mention 128 kB ranges at all.
each and addresses of F0002h, F2002h, F4002h, F6002h, F8002h, FA002h, FC002h and FE002h.
Those addresses are, respectively: hex decimal offset f0002 15*64k+0*4k+2 0k f2002 15*64k+2*4k+2 8k f4002 15*64k+4*4k+2 16k f6002 15*64k+6*4k+2 24k f8002 15*64k+8*4k+2 32k fa002 15*64k+10*4k+2 40k fc002 15*64k+12*4k+2 48k fe002 15*64k+14*4k+2 56k At a first glance, it is easy to assume an additional hex digit in the middle because we're so used to it. That may the reason you were seeing 128 kB blocks which I can't find here.
These 8 "sector-specific" lock bits are located at bit 0. Nowhere this table mentions anything about bits affecting only 8KB sized areas.
On the other hand, text of the data sheet nowhere mentions the sectorwise locking - it is just in the table. I have no idea how to read that.
Regards, Carl-Daniel -- http://www.hailfinger.org/
On Mon, 20 Jun 2011 01:59:30 +0200 Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> wrote:
Signed-off-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>
Killing sharplhf00l04.c is a good thing, though, so that part is Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
almost a year old... i took care of that in r1538. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner
participants (3)
-
Carl-Daniel Hailfinger -
Michael Karcher -
Stefan Tauner