Re: [flashrom] [PATCH 2/3] Factor out DMI string reading into subfunction - flashrom

24 Feb 2010


      On 24.02.2010 14:28, Michael Karcher wrote:
...
Signed-off-by: Michael Karcher flashrom@mkarcher.dialup.fu-berlin.de
Looks OK, but I'm in a hurry and couldn't check too thorougly. I need to
regenerate the diff with ignored whitespace to see the real changes.
Will do so later.
Right now, only a small coding style comment: You have
if (condition)
{
  block
}
in a few places. AFAIK flashrom coding style has the opening brace on
the same line as the if/do/switch statement. The only "standalone"
opening braces are those of functions.
Regards,
Carl-Daniel
-- 
"I do consider assignment statements and pointer variables to be among
computer science's most valuable treasures."
-- Donald E. Knuth