[PATCH] CID1130010: Resource leak

[Stefan Reinauer]

CID1130010: Resource leak

The system resource will not be reclaimed and reused, reducing the future
availability of the resource.
In verify_range: Leak of memory or pointers to system resources

Signed-off-by: Stefan Reinauer <[e-mail]>

Index: flashrom.c
===================================================================
--- flashrom.c	(revision 1763)
+++ flashrom.c	(working copy)
@@ -676,7 +676,8 @@
 
 	if (!flash->chip->read) {
 		msg_cerr("ERROR: flashrom has no read function for this flash chip.\n");
-		return 1;
+		ret = -1;
+		goto out_free;
 	}
 	if (!readbuf) {
 		msg_gerr("Could not allocate memory!\n");

[Stefan Tauner]

On Tue, 19 Nov 2013 20:35:57 +0100
Stefan Reinauer <[e-mail]> wrote:
> CID1130010: Resource leak
>
> The system resource will not be reclaimed and reused, reducing the future
> availability of the resource.
> In verify_range: Leak of memory or pointers to system resources
>
> Signed-off-by: Stefan Reinauer <[e-mail]>

Alternative solution attached.
-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner

[Stefan Tauner]

On Fri, 9 May 2014 00:22:52 +0200
Stefan Tauner <[e-mail]> wrote:
> Alternative solution attached.

Acked-by: Stefan Tauner <[e-mail]>
and committed in r1800.

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner