Re: [flashrom] Board identification patch for the MSC Q7 Tunnel Creek board

[Feldschmid, Ingo]

Hi,

thanks for all the input. I have created a new patch file, which
addresses the problems mentioned in the last few replies:

- print.c: added entry in boards_known array- board_enable.c: phase 2
function name changed to "p2_not_a_laptop"
- board_enable.c: new entry in board_matches array sorted by vendor name
- board_enable.c: board detection mechanism changed to use first pci
identifier for tunnel creek and  second pci identifier for EG20T and dmi
information for vendor name

The detection mechanism should now work for all boards with Tunnel Creek
CPU with EG20T southbridge from vendor "MSC Vertriebs GmbH". I tried to
narrow it down with the CPU/chipset/DMI combination, since we don't have
any company-specific pci devices on this board.

Signed-off-by: Ingo Feldschmid

Best regards,
Ingo

Es gelten unsere Allgemeinen Leistungsbedingungen die 
unter http://www.msc-ge.com/alb abrufbar sind.

Our standard terms and conditions apply which are 
available under http://www.msc-ge.com/alb .

MSC Vertriebs GmbH

Sitz der Gesellschaft:	Industriestrasse 16, 76297 Stutensee 
Handelsregister: 	Mannheim, HRB Nr. 10 3631
Geschaftsfuhrung: 	Manfred Schwarztrauber, Lothar Kummerlin, Rudiger Kuhn, Silvano Geissler
Umsatzsteuer ID Nr.: 	DE 143 585 507
WEEE Reg. Nr. :		DE 31011852

Gleichmann & Co. Electronics GmbH

Sitz der Gesellschaft:	Schraderstrasse 44, 67227 Frankenthal 
Handelsregister:	Ludwigshafen, HRB Nr. 21305
Geschaftsfuhrung:	Manfred Schwarztrauber, Thomas Klein
Umsatzsteuer ID Nr. :	DE 148 421 329            
WEEE Reg. Nr.:		DE 72277043

Diese E-Mail enthalt vertrauliche und/ oder rechtlich geschutzte Informationen. 
Wenn Sie nicht der beabsichtigte Empfanger sind, informieren Sie bitte sofort den
Absender und loschen Sie diese E-Mail.

The information contained in this message is confidential and/ or protected by law. 
If you are not the intended recipient, please contact the sender and delete this message.

Board identification patch for the MSC Q7 Tunnel Creek board

[Stefan Tauner]

On Mon, 30 Jan 2012 09:38:52 +0100
"Feldschmid, Ingo"  wrote:
> Hi,
>
> thanks for all the input. I have created a new patch file, which
> addresses the problems mentioned in the last few replies:
> print.c: added entry in boards_known array- board_enable.c: phase 2
>
> function name changed to "p2_not_a_laptop"
> board_enable.c: new entry in board_matches array sorted by vendor name
> board_enable.c: board detection mechanism changed to use first pci
>
> identifier for tunnel creek and  second pci identifier for EG20T and dmi
> information for vendor name
>
> The detection mechanism should now work for all boards with Tunnel Creek
> CPU with EG20T southbridge from vendor "MSC Vertriebs GmbH". I tried to
> narrow it down with the CPU/chipset/DMI combination, since we don't have
> any company-specific pci devices on this board.
>
> Signed-off-by: Ingo Feldschmid

thanks for the rework!

Acked-by: Stefan Tauner

i have changed a few things additionally: most noteworthy i have
changed the board enable to return 0 instead of 1. this is not checked
atm, but if it ever will, then 0 will be the right choice.
I have also added a debug print so that "DMI chassis-type is not
specific enough." is followed by "Laptop detection overridden by P2
board enable." in verbose output.

committed in r1487.

Board identification patch for the MSC Q7 Tunnel Creek board

[Carl-Daniel Hailfinger]

Am 31.01.2012 07:57 schrieb Stefan Tauner:
> On Mon, 30 Jan 2012 09:38:52 +0100
> "Feldschmid, Ingo"  wrote:
> > The detection mechanism should now work for all boards with Tunnel Creek
> > CPU with EG20T southbridge from vendor "MSC Vertriebs GmbH". I tried to
> > narrow it down with the CPU/chipset/DMI combination, since we don't have
> > any company-specific pci devices on this board.
> >
> > Signed-off-by: Ingo Feldschmid
>
> thanks for the rework!
>
> Acked-by: Stefan Tauner

Glad to see this merged. It's a good way to demonstrate how phase 2 in
board matching should be used.
> i have changed a few things additionally: most noteworthy i have
> changed the board enable to return 0 instead of 1. this is not checked
> atm, but if it ever will, then 0 will be the right choice.
> I have also added a debug print so that "DMI chassis-type is not
> specific enough." is followed by "Laptop detection overridden by P2
> board enable." in verbose output.

Yes, that makes sense. Thanks for reworking and fine-tuning this patch!

Regards,
Carl-Daniel