Hello everyone,
Today I had a first meeting with my mentor Anastasia. And I'm looking forward to see Thomas as soon as possible. We've discussed our project goals, initial tasks and current state of the code.
My next tasks: 1) Move all par masters to new API. It includes reducing the use of static global variables by storing them in a specific programmer data structure. 2) Introduce default shutdown function that can be very useful. We already have a patch for it: https://review.coreboot.org/c/flashrom/+/54890
It will be done in small steps/commits. So I hope to send a first patch soon.
Hello again,
After some time and several meetings with my mentors, we have a little progress in the topic.
1) Refactoring singleton state.
Move all masters to new API. It includes reducing the of static global variables. More detailed info in the issue tracker[1].
Merged: atahpt[2] Under review: drkaiser[3], gfxnvidia[4]
2) Restoring PCI value explicitly.
Programmers can restore a PCI value themselves in shutdown function. More detailed info in the issue tracker[1].
Under review: atahpt[6]
3) Introducing default shutdown func.
We haven't been coming to any agreement. The best way is to finish refactoring master API first. And after that we'll return to this issue. See the comment thread in the patch[7] for more details.
[1] https://ticket.coreboot.org/issues/391 [2] https://review.coreboot.org/c/flashrom/+/64963 [3] https://review.coreboot.org/c/flashrom/+/65194 [4] https://review.coreboot.org/c/flashrom/+/65342 [5] https://ticket.coreboot.org/issues/389 [6] https://review.coreboot.org/c/flashrom/+/65386 [7] https://review.coreboot.org/c/flashrom/+/54890
-- Joursoir
Hi everyone,
I want to share my progress with you. Let's move on to topics.
1) Refactoring singleton state.
Most of the simple cases are done. So, there are still non-trivial cases that require changes in the programmer map/unmap/delay API. Therefore, it would be tree-wide patches. The first one, which changes the programmer delay API, is already published[1]. If you're interested, take a look. Any comments are welcome!
Merged: drkaiser, gfxnvidia, mediatek_i2c_spi, it8212, atapromise, nicintel Under review: nicintel_eeprom[2], satamv[3], satasii[4], nicnatsemi[5]
2) Reduce global PCI state (ex. Restoring PCI value explicitly)
Now it's more bigger topic that it was. But actually I've been doing only restoring original PCI contents at the moment.
While atahpt[6] is still under review (hopefully it'll be merged soon), you can provide comments if you have any.
/* Joursoir */
[1] https://review.coreboot.org/c/flashrom/+/66373 [2] https://review.coreboot.org/c/flashrom/+/66158 [3] https://review.coreboot.org/c/flashrom/+/65978 [4] https://review.coreboot.org/c/flashrom/+/66075 [5] https://review.coreboot.org/c/flashrom/+/65970 [6] https://review.coreboot.org/c/flashrom/+/65386
-
Joursoir