On Mon, May 27, 2013 at 5:25 AM, Николай Николаев <evrinoma@gmail.com> wrote:

Hi steven,

2013/5/27 Steven Zakulec <spzakulec@gmail.com>

In the last review, I mentioned the Numonyx M45PE series (10, 20, 40, 80, 16), should only have
+        .feature_bits    = FEATURE_WRSR_WREN,

set when the command is there.  It appears I may have been unclear there, because instead of removing just the WREN flag, you removed the whole line (the chips do have a Write Status Register- WRSR).

Continuing the review from Numonyx M45PE16.

Sorry i don't know which flag must be used. You right these chips have a only WREN instruction, and i think if these chips doesn't have a feature that i exclude feature_bits. Maybe we will be able to specify the details.

Other people can provide more details on the general case, but in this instance, with only a WREN instruction, the FEATURE line should be:
 +        .feature_bits    = FEATURE_WRSR