Re: [flashrom] [PATCH] Add Nvidia nForce MCP6x/MCP7x series SPI flashing support

[Carl-Daniel Hailfinger]

On 28.07.2010 12:36, Uwe Hermann wrote:
> On Wed, Jul 28, 2010 at 03:13:42AM +0200, Carl-Daniel Hailfinger wrote:
> > Signed-off-by: Carl-Daniel Hailfinger <[e-mail]>
>
> Acked-by: Uwe Hermann <[e-mail]>
>
> Looks good, compile-tested and reviewed, also tested on hardware by
> various people.
> > +static void mcp6x_request_spibus(void)
> > +{
> > +	uint8_t byte;
>
> You use "byte" in most functions as variable name, but IIRC there were
> issues on some systems/compilers with this name. I recommend renaming to
> reg8 or tmp8 or the like.

Thanks for the review.
Renamed the identifier and committed in r1113.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/