On Sat, May 21, 2011 at 9:35 PM, Stefan Tauner <stefan.tauner@student.tuwien.ac.at> wrote:

On Sun, 22 May 2011 00:50:35 +0200
Idwer Vollering <vidwer@gmail.com> wrote:

> 2011/5/22 Rheneus <rheneus.paul@gmail.com>:
> > Support for Winbond W25Q128 (16384 KB, SPI)
> >
> > Signed-off-by: Antony <rheneus.paul@gmail.com>

sorry, this is not sufficient. we need your full real name in the
signed off line to include you as the author.

> To ease integration, can you resend your patch based on the latest
> development code?
> http://www.flashrom.org/Downloads#Installation_from_source

not necessary imho. i have it already integrated in my local HEAD (and
its a small change that does not need to/can not be tested, so there
is no real use of having it posted).

> > + .tested = TEST_OK_PRW,
>
> Have you tried to erase this chip as well and how did that work out?
> If erase works, please change TEST_OK_PRW to TEST_OK_PREW.

the .tested field in his patch is bogus. its probably a left over from
his copy&paste action. look at the -Vr log he provided in his mail from
2011-04-29. read fails (btw i would like to hear suggestions what the
cause might be :). i have set .tested to TEST_OK_PROBE.

--

Kind regards/Mit freundlichen Grüßen, Stefan Tauner