7 Oct
2010
7 Oct
'10
12:25 a.m.
2010/10/7 Uwe Hermann <uwe(a)hermann-uwe.de>
On Wed, Oct 06, 2010 at 02:00:35PM +0200, Carl-Daniel
Hailfinger wrote:
I think this is a better fix than this:
Index: Makefile
===================================================================
--- Makefile (revision 1196)
+++ Makefile (working copy)
@@ -26,7 +26,7 @@
DIFF = diff
PREFIX ?= /usr/local
MANDIR ?= $(PREFIX)/share/man
-CFLAGS ?= -Os -Wall -Wshadow
+CFLAGS ?= -Os -Wall -Wshadow -std=c99
EXPORTDIR ?= .
WARNERROR ?= yes
The above, with the patch in question applied, results in this error:
cc1: warnings being treated as errors
flashrom.c: In function ‘doit’:
flashrom.c:1596: error: implicit declaration of function ‘fileno’
make: *** [flashrom.o] Error 1
flashrom -L output did not contain a list of
programmers nor were all
programmers listed.
Fix it.
(Well, mostly. Some programmers have no devices listed. And formatting
on 80 column screens is totally broken for the flash chip list.)
Wiki output is unchanged, and will need separate fixups.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net
Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de>
But:
flashrom.c:1351: error: ‘for’ loop initial declarations are only allowed in
C99 mode
flashrom.c:1351: note: use option -std=c99 or -std=gnu99 to compile your
code
make: *** [flashrom.o] Error 1
I think this is the culprit:
for (int i = 0; i < startcol; i++)
printf(" ");
Moving the "int i;" to the top of the function should fix it.
However, I also think we should change the printing after 0.9.3 to fit
into 80 chars/line again. Names like
"W29C010(M)/W29C011A/W29EE011/W29EE012"
make it very hard though, we should shorten them.
Uwe.
--
http://hermann-uwe.de | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org
_______________________________________________
flashrom mailing list
flashrom(a)flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom