fix st95 rdid logic

сб, 21 дек. 2019 г. в 23:26, Николай Николаев <evrinoma@gmail.com>:

I've done the patch.

please find the attachment with patch and report

вс, 1 дек. 2019 г. в 23:30, David Hendricks <david.hendricks@gmail.com>:

Hello,
Thanks for the PR (https://github.com/flashrom/flashrom/pull/84). I
actually started to review this a long time ago, but apparently never
finished :-/ My bad.

The patch has a few merge conflicts, lots of dead code, and makes
changes that appear unrelated to ST 95XXX support. Please resolve the
merge conflicts and clean up the patch, and send another PR. Or better
yet, send directly to review.coreboot.org which is where upstream
review happens:
https://www.flashrom.org/Development_Guidelines#Sending_a_patch

On Sun, Dec 1, 2019 at 12:18 PM Николай Николаев <evrinoma@gmail.com> wrote:
>
> Hello
> My pull request has already been created that had occurred several months previously. I added support for ST 95XXX chips . The following chipsets have been successfully tested for read, erase and write operations: ST [ 95080, 95160, 95320, 95640, 95128, 95256 ]. I would like to discuss a new features.
> Maybe someone in the community will spent a bit of time and review my pull request. Don't worry about the conflicting files. The part of the code has already been merged into effect.
>
> I'm open-minded and ready.
>
>
> _______________________________________________
> flashrom mailing list -- flashrom@flashrom.org
> To unsubscribe send an email to flashrom-leave@flashrom.org