Thanks, Anastasia,

Can you please explain this statement,

.printlock  = SPI_PRETTYPRINT_STATUS_REGISTER_BP4_SRWD,
.unlock     = SPI_DISABLE_BLOCKPROTECT_BP4_SRWD,

Looks like this is to support memory array protection. But it needs BP0-BP4.
Do I need to specify BP0 to BP3 as well?
Or I specify the setting when I initiate the flashrom programming command?

Regards,

Victor


From: Anastasia Klimchuk <aklm@chromium.org>
Sent: Thursday, March 21, 2024 05:32
To: Vlim <vlim@gigadevice.com>; flashrom@flashrom.org <flashrom@flashrom.org>
Cc: Peter Marheine <pmarheine@chromium.org>
Subject: [flashrom] Re: adding part #
 
You don't often get email from aklm@chromium.org. Learn why this is important
此为外部邮件,谨防钓鱼邮件,请注意邮件是否涉及敏感信息
This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information
Hello Victor,

Various feature bits are defined as macros in include/flash.h , some of them have comments explaining what they do. If the feature name is not descriptive, and there is no comment, but you think you might need this feature: feel free to ask. I would try to add comments later.

SPI_DISABLE_BLOCKPROTECT_BP4_SRWD and other unlock functions as in spi25_statusreg.c. Those functions have comments, hopefully this can help!

On Thu, Mar 21, 2024 at 2:48 PM Vlim <vlim@gigadevice.com> wrote:
Thanks, Peter,

Where can I find the definition of terms like,

.feature_bits     = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_WRSR_EXT2,
SPI_DISABLE_BLOCKPROTECT_BP4_SRWD

Regards,

Victor



From: Peter Marheine <pmarheine@chromium.org>
Sent: Tuesday, March 19, 2024 15:42
To: Vlim <vlim@gigadevice.com>
Cc: flashrom@flashrom.org <flashrom@flashrom.org>
Subject: Re: [flashrom] adding part #
 
此为外部邮件,谨防钓鱼邮件,请注意邮件是否涉及敏感信息
This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information
Our "how to add a new chip" documentation should point you in the right direction: https://flashrom.org/contrib_howtos/how_to_add_new_chip.html

But feel free to ask further questions if anything there doesn't seem sufficient for your needs.

On Wed, Mar 20, 2024 at 6:31 AM Vlim <vlim@gigadevice.com> wrote:
Hi, FlashRom team,

I am the FAE director in Gigadevice and I would like to add some part #s to the flashchip.c and flashchip.h.
Can you please provide some guidance?

Regards,

Victor Lim
FAE Director
GigaDevice Semiconductor
4088833856

_______________________________________________
flashrom mailing list -- flashrom@flashrom.org
To unsubscribe send an email to flashrom-leave@flashrom.org
_______________________________________________
flashrom mailing list -- flashrom@flashrom.org
To unsubscribe send an email to flashrom-leave@flashrom.org


--
Anastasia.