On Mon, 2010-07-12 at 00:33 +0200, Carl-Daniel Hailfinger wrote:

Hi Daniel,

thanks for your patch.

Could I interest you in implementing support for all other AMIC A25
series chips as well? Even if you can't test those, it would expand
flashrom coverage a lot.

Sure, I can do that.  Patched attached, for A25L{05,10,20,40,80,16}P{T,U}, as well as generic AMIC and a pretty-printer function for their status register.

Signed-off-by: Daniel Lenski <dlenski@gmail.com>

Now here's something weird: the AMIC datasheets, which have lots of errata and different versions, are riddled with strange errors and omissions, probably due to quick-and-dirty copy-and-pasting by whoever's writing or translating them.

A quick search of Datasheetarchive.com suggests that the following parts exist:
A25L05P[TU] - ID 2020/2010 (T/U)
A25L10P[TU] - ID 2021/2011 (T/U)
A25L20P[TU] - ID 2022/2012 (T/U)
A25L40P[TU] - ID      2013 (Datasheet says same ID for U *and* T)
A25L80P     - ID      2014 (No T exists, it seems)
A25L16P[TU] - ID 2025/2015 (T/U)

I'm willing to bet that A25L40PT has the device ID 2023, and *not* 2013.  The only way to distinguish it from the A25L40PU would be by selective block erasing, and it appears that Erase is untested for those chips.  So, my patch changes the model_ID for A25L40PT to be 2023, as I think it should be according to the pattern, rather than 2013 as the datasheet claims.

Dan