Am Sonntag, den 15.08.2010, 20:26 +0200 schrieb Mattias Mattsson:
One question remaining: Why do you think GPO8 is "never available". The only special behaviour about GPO8 I could find in the data sheet is that GPO8 has a defined low level in standby mode, but it should work as usual in all other modes.
While experimenting I found that some board immediately powered off when lowering GPO8 (think it was a Dell, unfortunately it's dead now).
Strange behaviour on randomly touching GPIO pins is quite common, don't worry about that. There is a reason we don't run untested board enables by default.
It seems safe in most cases so I decided to just remove the forbidden_gpos variable and mark GPO8 as always available.
Right. Flashrom can't know what GPO8 is wired to on the specific mainboard it runs on, so it has no chance to know whether it should better not touch it.
Also I marked all board enables using intel_piix4_gpo_set as untested (and renamed the function to the more generic form).
New patch attached
Acked-by: Michael Karcher email@example.com and committed as r1142.
Thanks for your contribution!
Regards, Michael Karcher