On Fri, Oct 29, 2010 at 2:27 PM, Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006@gmx.net> wrote:
On 29.10.2010 22:51, David Hendricks wrote:
> When running the script, it seems that the added "$FLASHROM_PARAM" can get
> expanded incorrectly by the shell thus causing flashrom to barf when
> $FLASHROM_PARAM is empty. I suspect it quietly passes in "".
>
> The attached patch is a simple s/\"$FLASHROM_PARAM\"/${FLASHROM_PARAM}/g.
> This seems to work.
>
> My shell-fu is only moderate, perhaps someone with more expertise can verify
> that this is the -correct- way to do it.
>
If you reply to this with a Signed-off-by line, this is
D'oh! Thanks again for catching my silly mistakes. The fix-parameter-passing-shell-stupidity.patch is: