On Wed, 11 Jun 2014 01:46:31 +0200 Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
Am 09.06.2014 14:41 schrieb Stefan Tauner:
This function clearly belongs to the command line interface and should therefore reside in cli_classic.c and not in flashrom.c.
Signed-off-by: Stefan Tauner stefan.tauner@alumni.tuwien.ac.at
Except for the last msg_ in that function, how does this belong to the command line? You'd want the same functionality and messages (save for the last one) if you're using a GUI.
Functionality maybe, messages certainly not. Separating them is not really practicable, but if you want to give it a try... As it is right now it clearly is clearly a UI component and does not belong to the core. We need to cleanup flashrom.c and we need to start somewhere. If you think it is a mandatory UI function then we could create a ui_common, ui_basic or whatever file. I dont think it would be right though, and even then it could be moved there later when really needed.