Re: [flashrom] [PATCH] C99 cleanliness

[Uwe Hermann]

On Thu, Oct 07, 2010 at 02:52:43AM +0200, Carl-Daniel Hailfinger wrote:
  The above,
with the patch in question applied, results in this error:

 cc1: warnings being treated as errors
 flashrom.c: In function ‘doit’:
 flashrom.c:1596: error: implicit declaration of function ‘fileno’
 
 Mh yes, once you switch the mode from gnu99 to c99, you get all sorts of
 pretty explosions.
Guess so, too.


  The following patch allows compilation with -std=c99
on my Linux box
 with gcc and clang, but I fear it will cause all sorts of funnies on
 other operating systems, and especially break on Windows.
 
 This patch is for testing on non-Linux architectures, and _not_ for
 immediate merge.
 
 Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net>
Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de>

I think it's probably OK to merge it anyway (after 0.9.3), but without the
addition of -std=c99 in the Makefile. Also volatile -> __volatile__
maybe too, while we're at it.


Uwe.
-- 
http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org