On Thu, 07 Apr 2011 19:16:04 +0200 Michael Karcher flashrom@mkarcher.dialup.fu-berlin.de wrote:
Am Donnerstag, den 07.04.2011, 18:40 +0200 schrieb Stefan Reinauer:
- Michael Karcher flashrom@mkarcher.dialup.fu-berlin.de
Not every OS has a unix command interpreter. This will break on DOS. Most likely fine if DOS is detected per ifdef.
Ok, how about this one?
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org
Acked-by: Michael Karcher flashrom@mkarcher.dialup.fu-berlin.de
+#if defined (__DJGPP__) || defined (_WIN32)
That might be overly conservative, but I am fine with out. while command.com does not support 2>something, I am quite sure cmd.exe does.
stepan told me to commit this, but i hesitate. i want to integrate dos/win support first.
i would drop the __DJGPP__ flag there because /dev/null is supported by it: http://www.delorie.com/djgpp/doc/eli-m17n99.html#Unix%20devices additionally i would use 2>NUL for win32. for xp there is official documentation. a friend of mine also tried it on win2k so i would say it is fairly safe to use it?